Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump postgresql in docker-compose and github workflows #24147

Merged
merged 3 commits into from
Jul 24, 2023

Conversation

sebastianliebscher
Copy link
Contributor

@sebastianliebscher sebastianliebscher commented May 20, 2023

SUMMARY

This PR bumps to postgresql:15 image version in Dockerfile and GH workflows.


Postgres 15.0 change log: https://www.postgresql.org/docs/release/15.0/

From Postgres release news:

In this latest release, PostgreSQL improves on its in-memory and on-disk sorting algorithms, with benchmarks showing speedups of 25% - 400% based on which data types are sorted. Using row_number(), rank(), dense_rank(), and count() as window functions also have performance benefits in PostgreSQL 15. Queries using SELECT DISTINCT can now be executed in parallel.


Note: The Helm Chart already uses PostgreSQL 15 as introduced in #22590. Version >=12 uses postgres 15.X. See https://github.com/bitnami/charts/tree/main/bitnami/postgresql/#to-1200

TESTING INSTRUCTIONS

./scripts/tests/run.sh and all CI jobs run successfully

@codecov
Copy link

codecov bot commented May 20, 2023

Codecov Report

Merging #24147 (deee9c4) into master (0496779) will increase coverage by 0.10%.
The diff coverage is 81.44%.

❗ Current head deee9c4 differs from pull request most recent head f954916. Consider uploading reports for the commit f954916 to get more accurate results

@@            Coverage Diff             @@
##           master   #24147      +/-   ##
==========================================
+ Coverage   68.18%   68.28%   +0.10%     
==========================================
  Files        1952     1955       +3     
  Lines       75393    75493     +100     
  Branches     8204     8220      +16     
==========================================
+ Hits        51403    51553     +150     
+ Misses      21884    21833      -51     
- Partials     2106     2107       +1     
Flag Coverage Δ
hive 53.34% <57.64%> (?)
javascript 54.68% <56.86%> (+<0.01%) ⬆️
mysql 78.96% <82.35%> (+0.02%) ⬆️
postgres 79.02% <82.35%> (+0.01%) ⬆️
presto 53.27% <57.64%> (+0.10%) ⬆️
python 82.85% <88.82%> (+0.21%) ⬆️
sqlite 77.56% <81.76%> (+0.02%) ⬆️
unit 53.38% <72.94%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i-core/src/color/colorSchemes/sequential/common.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...plugins/legacy-preset-chart-deckgl/src/factory.tsx 0.00% <ø> (ø)
...preset-chart-deckgl/src/layers/Heatmap/Heatmap.tsx 0.00% <0.00%> (ø)
...d/plugins/legacy-preset-chart-deckgl/src/preset.js 100.00% <ø> (ø)
...-frontend/src/features/alerts/AlertReportModal.tsx 54.44% <0.00%> (ø)
...end/src/features/databases/DatabaseModal/index.tsx 43.63% <ø> (ø)
superset/charts/api.py 87.07% <ø> (+0.98%) ⬆️
superset/commands/importers/v1/assets.py 88.09% <0.00%> (+2.04%) ⬆️
superset/constants.py 100.00% <ø> (ø)
... and 55 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@RealGreenDragon
Copy link

Thank you for the PR, you beat me on time !

Only an advice: docs should be updated to add v15, as done in PR #19790

@sebastianliebscher
Copy link
Contributor Author

@RealGreenDragon thank you; done!

@rusackas
Copy link
Member

@villebro @john-bodley @betodealmeida see any risk here?

@rusackas rusackas merged commit c17accc into apache:master Jul 24, 2023
30 checks passed
@sebastianliebscher sebastianliebscher deleted the bump_pg branch July 25, 2023 09:19
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants