Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adding some component dosctrings generated by GPT #24164

Closed
wants to merge 3 commits into from

Conversation

rusackas
Copy link
Member

SUMMARY

Adds JSDoc-esque docstrings to the (randomly selected) DropDownButton and EmptyState components

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #24164 (c0709b2) into master (febc07a) will decrease coverage by 11.27%.
The diff coverage is 25.92%.

❗ Current head c0709b2 differs from pull request most recent head 0afd8d1. Consider uploading reports for the commit 0afd8d1 to get more accurate results

@@             Coverage Diff             @@
##           master   #24164       +/-   ##
===========================================
- Coverage   68.27%   57.00%   -11.27%     
===========================================
  Files        1952     1955        +3     
  Lines       75369    75379       +10     
  Branches     8210     8215        +5     
===========================================
- Hits        51457    42972     -8485     
- Misses      21806    30301     +8495     
  Partials     2106     2106               
Flag Coverage Δ
hive ?
javascript 54.68% <25.92%> (-0.02%) ⬇️
mysql ?
postgres ?
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...i-core/src/color/colorSchemes/sequential/common.ts 100.00% <ø> (ø)
...plugins/legacy-preset-chart-deckgl/src/factory.tsx 0.00% <ø> (ø)
...preset-chart-deckgl/src/layers/Heatmap/Heatmap.tsx 0.00% <0.00%> (ø)
...d/plugins/legacy-preset-chart-deckgl/src/preset.js 100.00% <ø> (ø)
...t-frontend/src/components/DropdownButton/index.tsx 85.00% <ø> (ø)
...erset-frontend/src/components/EmptyState/index.tsx 83.67% <ø> (ø)
superset/config.py 91.37% <ø> (-0.60%) ⬇️
superset/dashboards/permalink/api.py 58.82% <ø> (-30.07%) ⬇️
superset/dashboards/permalink/commands/base.py 87.50% <ø> (-12.50%) ⬇️
superset/dashboards/permalink/commands/create.py 50.00% <ø> (-42.86%) ⬇️
... and 12 more

... and 296 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas requested a review from eschutho May 23, 2023 14:33
@rusackas
Copy link
Member Author

rusackas commented Jun 8, 2023

Let's just... not do this.

@rusackas rusackas closed this Jun 8, 2023
@mistercrunch mistercrunch deleted the gpt-component-dosctrings branch March 26, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant