Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): rendering regression on standalone #24177

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented May 22, 2023

SUMMARY

This commit fixes the rendering regression in standalone mode(and reports) by #23778
The issue is the standalone renders the chart container only so there's no observeRef exists to initialize the chart size.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
(Render a chart in a standalone)

Before:
(Empty screen)

TESTING INSTRUCTIONS

Go to any chart explore link
Add &standalone=true parameter at the end

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #24177 (8113d88) into master (455e23b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 8113d88 differs from pull request most recent head 6157d15. Consider uploading reports for the commit 6157d15 to get more accurate results

@@            Coverage Diff             @@
##           master   #24177      +/-   ##
==========================================
+ Coverage   68.27%   68.28%   +0.01%     
==========================================
  Files        1955     1955              
  Lines       75451    75451              
  Branches     8215     8215              
==========================================
+ Hits        51511    51522      +11     
+ Misses      21834    21825       -9     
+ Partials     2106     2104       -2     
Flag Coverage Δ
javascript 54.70% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...src/explore/components/ExploreChartPanel/index.jsx 77.63% <100.00%> (+7.89%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley merged commit 8e45af4 into apache:master May 23, 2023
29 checks passed
justinpark added a commit to airbnb/superset-fork that referenced this pull request May 23, 2023
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 23, 2023
@sadpandajoe
Copy link
Contributor

🏷️ preset:2023.21

justinpark added a commit to airbnb/superset-fork that referenced this pull request May 25, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants