Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove user registrations menu for non-admins #24198

Merged
merged 3 commits into from Jun 13, 2023

Conversation

villebro
Copy link
Member

@villebro villebro commented May 24, 2023

SUMMARY

Currently only Admins have "menu access on Security", but despite that, non-admins have "menu access on User's Statistics" and "menu access on "User Registrations" which belong under the "Security" menu. This removes menu access, as they aren't really able to access the menu. We also bump FAB to the lastest version, which includes a fix to the "User Registrations" view registration: dpgaspar/Flask-AppBuilder#2051

AFTER

After the change, a Gamma user with Alerts & Reports and RLS access will only see the RLS menu under Security:
image

BEFORE

Previously, they would also see the User Registrations menu:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #24198 (f699b25) into master (6f145df) will increase coverage by 1.70%.
The diff coverage is n/a.

❗ Current head f699b25 differs from pull request most recent head 664235a. Consider uploading reports for the commit 664235a to get more accurate results

@@            Coverage Diff             @@
##           master   #24198      +/-   ##
==========================================
+ Coverage   67.27%   68.98%   +1.70%     
==========================================
  Files        1903     1903              
  Lines       74275    74275              
  Branches     8110     8110              
==========================================
+ Hits        49971    51241    +1270     
+ Misses      22192    20922    -1270     
  Partials     2112     2112              
Flag Coverage Δ
hive 53.98% <ø> (ø)
mysql 79.34% <ø> (ø)
postgres ?
presto 53.90% <ø> (?)
python 83.29% <ø> (+3.54%) ⬆️
sqlite 77.92% <ø> (ø)
unit 54.39% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/security/manager.py 93.83% <ø> (ø)

... and 104 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie self-requested a review May 24, 2023 22:08
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina
Copy link
Member

michael-s-molina commented May 25, 2023

@villebro Could you include something in UPDATING.md?

@villebro
Copy link
Member Author

@villebro Could you include something in UPDATING.md?

Good idea @michael-s-molina - there may be a small change forthcoming in FAB that requires me to add one more line to this diff, so I'm waiting for confirmation on this from @dpgaspar before proceeding

@villebro villebro force-pushed the villebro/disable-registration-menu branch 2 times, most recently from 3dd81f3 to a62a120 Compare June 13, 2023 09:52
@villebro villebro force-pushed the villebro/disable-registration-menu branch from a62a120 to 664235a Compare June 13, 2023 10:35
Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit c09b8c6 into apache:master Jun 13, 2023
29 checks passed
@villebro villebro deleted the villebro/disable-registration-menu branch June 13, 2023 11:04
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants