Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removing problematic "formattable" tag #24207

Merged
merged 1 commit into from
May 26, 2023
Merged

Conversation

rusackas
Copy link
Member

SUMMARY

Addresses a valid point in #16340 - searching for "table" is super common. "Formattable" is not a terribly useful category (I suspect) nor is it comprehensively populated it. So, I'm axing it. I'm open to other ideas :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Fixes [gallery] Remove the "Formattable" tag for chart types #16340
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #24207 (a6dcb06) into master (c54eedf) will increase coverage by 0.00%.
The diff coverage is 75.00%.

❗ Current head a6dcb06 differs from pull request most recent head c38f135. Consider uploading reports for the commit c38f135 to get more accurate results

@@           Coverage Diff           @@
##           master   #24207   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files        1957     1957           
  Lines       75588    75590    +2     
  Branches     8223     8223           
=======================================
+ Hits        51633    51635    +2     
  Misses      21848    21848           
  Partials     2107     2107           
Flag Coverage Δ
javascript 54.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-echarts/src/BigNumber/BigNumberTotal/index.ts 66.66% <ø> (ø)
...arts/src/BigNumber/BigNumberWithTrendline/index.ts 66.66% <ø> (ø)
...t-frontend/plugins/plugin-chart-table/src/index.ts 66.66% <ø> (ø)
superset/extensions/ssh.py 67.50% <66.66%> (+0.83%) ⬆️
superset/config.py 92.00% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit cc68d62 into master May 26, 2023
52 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the remove-formattable-tag branch March 26, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gallery] Remove the "Formattable" tag for chart types
3 participants