Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): creating default superset_text.yaml placeholder file #24250

Merged
merged 4 commits into from
Jun 5, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

Gets rid of a frequently reported warning about a missing file by providing one! The file will remain git-ignored for people to freely edit.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #24250 (5908ac6) into master (674da1b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24250   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files        1957     1957           
  Lines       75596    75596           
  Branches     8222     8222           
=======================================
  Hits        51639    51639           
  Misses      21849    21849           
  Partials     2108     2108           
Flag Coverage Δ
hive 53.36% <ø> (ø)
javascript 54.72% <ø> (ø)
mysql 78.91% <ø> (ø)
postgres 78.99% <ø> (ø)
presto 53.29% <ø> (ø)
python 82.81% <ø> (ø)
sqlite 77.53% <ø> (ø)
unit 53.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rusackas rusackas merged commit 18d2257 into master Jun 5, 2023
51 checks passed
@michael-s-molina
Copy link
Member

@rusackas When running npm run dev-server the module is returning null and breaking the app.

@michael-s-molina
Copy link
Member

@rusackas When running npm run dev-server the module is returning null and breaking the app.

I submitted a fix here.

@rusackas rusackas deleted the default-superset_text branch June 8, 2023 17:38
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants