Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tests for #24249 #24251

Merged
merged 1 commit into from
May 31, 2023
Merged

chore: tests for #24249 #24251

merged 1 commit into from
May 31, 2023

Conversation

betodealmeida
Copy link
Member

SUMMARY

Add tests for #24249.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #24251 (3351d1c) into master (7e70f19) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 3351d1c differs from pull request most recent head 0e0e7da. Consider uploading reports for the commit 0e0e7da to get more accurate results

@@            Coverage Diff             @@
##           master   #24251      +/-   ##
==========================================
- Coverage   68.30%   68.28%   -0.02%     
==========================================
  Files        1957     1957              
  Lines       75596    75596              
  Branches     8222     8222              
==========================================
- Hits        51639    51624      -15     
- Misses      21849    21864      +15     
  Partials     2108     2108              
Flag Coverage Δ
javascript 54.72% <ø> (ø)
mysql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/dashboard/util/permissionUtils.ts 86.66% <ø> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida merged commit a3bbe35 into master May 31, 2023
52 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the tests_for_24249 branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants