chore(deps): bump typescript to 4.8.4 #24272

jansule · 2023-06-02T09:40:43Z

SUMMARY

This bumps typescript from 4.5.4 to 4.8.4. @typescript-eslint/eslint-plugin and @typescript-eslint/parser were upgraded to 5.42.1 to match the typescript version.

New TSERRORs were fixed where possible. Unfortunately, I had to add a few @ts-ignores here and there. Maybe someone with a deeper understanding of the code base is able to fix these errors properly.

I decided to bump to typescript 4.8.4 as work related to #21758 introduced an upgrade to this version anyways. In consultation with @villebro we decided to create a dedicated PR for this.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Simply run the tests and build the application to see if any TSERRORs occur.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

github-actions

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

villebro

Thanks for the bump! A few small comments, but looks good in general 👍

superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx

villebro · 2023-06-02T10:25:40Z

superset-frontend/plugins/plugin-chart-table/src/utils/extent.ts

@@ -24,16 +24,16 @@ export default function extent<T = number | string | Date | undefined | null>(
  // eslint-disable-next-line no-restricted-syntax
  for (const value of values) {
    if (value !== null) {
-      if (min === undefined) {
+      if (min === undefined || min === null) {


Maybe we could use _.isNil here?

let _ = require('lodash'); > _.isNil(undefined) true > _.isNil(null) true > _.isNil(0) false > _.isNil('') false

Done in cbcc0ee

villebro · 2023-06-02T10:26:52Z

superset-frontend/plugins/plugin-chart-table/src/utils/extent.ts

        if (min > value) {
          min = value;
        }
-        if (max !== undefined) {
+        if (max !== undefined && max !== null) {


Maybe

Suggested change

if (max !== undefined && max !== null) {

if (!isNil(max)) {

Done in cbcc0ee

villebro · 2023-06-02T10:27:55Z

superset-frontend/plugins/plugin-chart-word-cloud/src/chart/WordCloud.tsx

@@ -158,6 +158,7 @@ class WordCloud extends React.PureComponent<
  update() {
    const { data, encoding } = this.props;

+    // @ts-ignore


not a huge deal, but I'd be curious to understand what the error was here, do you have it handy?

Sure, it's

Argument of type 'Partial<DeriveEncoding<WordCloudEncodingConfig>>' is not assignable to parameter of type 'never'

Oh, I just noticed it's still a class component. Let's revisit this some day when it's migrated to a functional component.

codecov · 2023-06-02T11:31:57Z

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (64ba579) 67.22% compared to head (39706d4) 67.22%.

Files	Patch %	Lines
...end/plugins/plugin-chart-table/src/utils/extent.ts	0.00%	3 Missing ⚠️
...nd/plugins/plugin-chart-table/src/controlPanel.tsx	0.00%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #24272      +/-   ##
==========================================
- Coverage   67.22%   67.22%   -0.01%     
==========================================
  Files        1895     1895              
  Lines       74211    74212       +1     
  Branches     8245     8246       +1     
==========================================
  Hits        49891    49891              
- Misses      22248    22249       +1     
  Partials     2072     2072

Flag	Coverage Δ
javascript	`56.98% <37.50%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

EugeneTorap · 2023-08-01T05:22:41Z

Hey @jansule! Can you merge master to your branch?

jansule · 2023-08-15T09:51:02Z

@EugeneTorap Sorry for the late reply. I will try to find time this week to rebase against current master.

jansule · 2023-08-16T13:57:02Z

@EugeneTorap just rebased against current master. Locally, the build succeeded.

EugeneTorap · 2023-08-16T18:17:53Z

Hey @michael-s-molina! Can you review this PR?

villebro · 2023-11-27T17:42:58Z

@jansule sorry for missing this PR - would you be able to rebase this so we can get it merged?

villebro

LGTM, unless the rebase turns up some new issues

jansule · 2023-12-04T15:16:34Z

@villebro I just rebased against current master. Locally the build is passing (docker build --target lean .). I also clicked very briefly through the application and did not encounter issues.

rusackas · 2023-12-07T16:36:35Z

Running CI 🤞

jansule · 2023-12-14T12:04:37Z

I'm not sure how to interpret the failing check https://github.com/apache/superset/actions/runs/7088616773/job/19419142631?pr=24272:

────────────────────────────────────────────────────────────────────────────────────────────────────
                                                                                                      
    Running:  explore/visualizations/sankey.test.js                                         (31 of 53)
    Estimated: 18 seconds
  
  
    Visualization > Sankey
      ✓ should work (3946ms)
      ✓ should work with filter (2418ms)
  Error: The operation was canceled.

I would be grateful, if somebody could give me hints here.

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

pull-request-size bot added the size/M label Jun 2, 2023

github-actions bot reviewed Jun 2, 2023

View reviewed changes

villebro reviewed Jun 2, 2023

View reviewed changes

jansule force-pushed the typescript-upgrade branch from cbcc0ee to 71e2886 Compare June 2, 2023 12:08

jansule force-pushed the typescript-upgrade branch from 71e2886 to cf1d55a Compare August 16, 2023 13:56

jansule mentioned this pull request Nov 6, 2023

feat(plugin): add plugin-chart-cartodiagram #25869

Open

9 tasks

villebro approved these changes Nov 27, 2023

View reviewed changes

jansule force-pushed the typescript-upgrade branch from cf1d55a to e6fa6b9 Compare December 4, 2023 15:14

jansule and others added 3 commits January 29, 2024 16:22

chore(deps): bump typescript to 4.8.4

5321dcc

Apply suggestions from code review

e15da02

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

style: replace NP checks with isNil

39706d4

jansule force-pushed the typescript-upgrade branch from e6fa6b9 to 39706d4 Compare January 29, 2024 15:22

rusackas merged commit 29582e8 into apache:master Jan 29, 2024
32 checks passed

eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024

chore(deps): bump typescript to 4.8.4 (apache#24272)

fddc618

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024

chore(deps): bump typescript to 4.8.4 (apache#24272)

cde1b95

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024

marcjansen deleted the typescript-upgrade branch June 4, 2024 14:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(deps): bump typescript to 4.8.4 #24272

chore(deps): bump typescript to 4.8.4 #24272

jansule commented Jun 2, 2023

github-actions bot left a comment

villebro left a comment

villebro Jun 2, 2023

jansule Jun 2, 2023

villebro Jun 2, 2023

jansule Jun 2, 2023

villebro Jun 2, 2023

jansule Jun 2, 2023 •

edited

Loading

villebro Jun 2, 2023

codecov bot commented Jun 2, 2023 •

edited

Loading

EugeneTorap commented Aug 1, 2023

jansule commented Aug 15, 2023

jansule commented Aug 16, 2023

EugeneTorap commented Aug 16, 2023

villebro commented Nov 27, 2023

villebro left a comment

jansule commented Dec 4, 2023

rusackas commented Dec 7, 2023

jansule commented Dec 14, 2023 •

edited

Loading

chore(deps): bump typescript to 4.8.4 #24272

chore(deps): bump typescript to 4.8.4 #24272

Conversation

jansule commented Jun 2, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

github-actions bot left a comment

Choose a reason for hiding this comment

villebro left a comment

Choose a reason for hiding this comment

villebro Jun 2, 2023

Choose a reason for hiding this comment

jansule Jun 2, 2023

Choose a reason for hiding this comment

villebro Jun 2, 2023

Choose a reason for hiding this comment

jansule Jun 2, 2023

Choose a reason for hiding this comment

villebro Jun 2, 2023

Choose a reason for hiding this comment

jansule Jun 2, 2023 • edited Loading

Choose a reason for hiding this comment

villebro Jun 2, 2023

Choose a reason for hiding this comment

codecov bot commented Jun 2, 2023 • edited Loading

Codecov Report

EugeneTorap commented Aug 1, 2023

jansule commented Aug 15, 2023

jansule commented Aug 16, 2023

EugeneTorap commented Aug 16, 2023

villebro commented Nov 27, 2023

villebro left a comment

Choose a reason for hiding this comment

jansule commented Dec 4, 2023

rusackas commented Dec 7, 2023

jansule commented Dec 14, 2023 • edited Loading

jansule Jun 2, 2023 •

edited

Loading

codecov bot commented Jun 2, 2023 •

edited

Loading

jansule commented Dec 14, 2023 •

edited

Loading