Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure json is not None #24280

Merged
merged 1 commit into from
Jun 3, 2023

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Jun 3, 2023

Fixing a migration

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho requested a review from a team as a code owner June 3, 2023 01:40
@codecov
Copy link

codecov bot commented Jun 3, 2023

Codecov Report

Merging #24280 (0e5995f) into master (c5ea40f) will not change coverage.
The diff coverage is n/a.

❗ Current head 0e5995f differs from pull request most recent head f650221. Consider uploading reports for the commit f650221 to get more accurate results

@@           Coverage Diff           @@
##           master   #24280   +/-   ##
=======================================
  Coverage   68.31%   68.31%           
=======================================
  Files        1957     1957           
  Lines       75624    75624           
  Branches     8223     8223           
=======================================
  Hits        51664    51664           
  Misses      21852    21852           
  Partials     2108     2108           
Flag Coverage Δ
hive 53.39% <ø> (ø)
mysql 78.92% <ø> (ø)
postgres 79.00% <ø> (ø)
presto 53.32% <ø> (ø)
python 82.82% <ø> (ø)
sqlite 77.53% <ø> (ø)
unit 53.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@craig-rueda craig-rueda merged commit 40fffc3 into apache:master Jun 3, 2023
29 checks passed
@craig-rueda craig-rueda deleted the elizabeth/fix-migration branch June 3, 2023 15:19
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jun 5, 2023
@sadpandajoe
Copy link
Contributor

🏷️ preset:2023.21

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants