Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update order of build for testing a release #24317

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Jun 8, 2023

SUMMARY

Due to a recent change in dataset permissions the release testing file needed to be updated in order to ensure that the correct permissions were build before running the tarball.

This change only impacts the release testing process.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley
Copy link
Member

@eschutho grokking the rest of the codebase it seems like the order is mostly correct, i.e., how you've defined it, except for this. Would you mind also updating said logic there as well?

@eschutho
Copy link
Member Author

eschutho commented Jun 8, 2023

Sure, no problem. @betodealmeida also showed me this pr that loads examples as an anonymous user and should take care of any problems loading before running init, but at least this is all consistent now.

@eschutho eschutho merged commit af8f725 into apache:master Jun 8, 2023
28 checks passed
@eschutho eschutho deleted the elizabeth/fix-release-build branch June 8, 2023 23:30
@mistercrunch mistercrunch added 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants