Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated api /superset/filter/... #24335

Merged
merged 5 commits into from Jun 12, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jun 9, 2023

SUMMARY

Removes old deprecated API /superset/filter/<datasource_type>/<int:datasource_id>/<column>/ use /api/v1/datasource/<datasource_type>/<datasource_id>/column/<column_name>/values/ instead

First PR on the effort on removing deprecated API from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar requested a review from a team June 9, 2023 01:12
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #24335 (0604e50) into master (3d9c7d4) will increase coverage by 1.66%.
The diff coverage is 100.00%.

❗ Current head 0604e50 differs from pull request most recent head 876104a. Consider uploading reports for the commit 876104a to get more accurate results

@@            Coverage Diff             @@
##           master   #24335      +/-   ##
==========================================
+ Coverage   67.42%   69.08%   +1.66%     
==========================================
  Files        1903     1903              
  Lines       74604    74590      -14     
  Branches     8107     8107              
==========================================
+ Hits        50301    51534    +1233     
+ Misses      22192    20945    -1247     
  Partials     2111     2111              
Flag Coverage Δ
hive 53.78% <100.00%> (+<0.01%) ⬆️
mysql 79.39% <100.00%> (-0.01%) ⬇️
postgres 79.46% <100.00%> (-0.01%) ⬇️
presto 53.71% <100.00%> (+<0.01%) ⬆️
python 83.38% <100.00%> (+3.43%) ⬆️
sqlite 77.98% <100.00%> (-0.01%) ⬇️
unit 54.20% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 76.03% <100.00%> (-0.20%) ⬇️

... and 95 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas requested a review from john-bodley June 9, 2023 02:03
UPDATING.md Outdated
@@ -24,6 +24,7 @@ assists people when migrating to a new version.

## Next

- [---](https://github.com/apache/superset/pull/---): Removed deprecated API `/superset/filter/<datasource_type>/<int:datasource_id>/<column>/`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to the Breaking Changes section and add the PR number?

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit 2df699c into apache:master Jun 12, 2023
29 checks passed
@dpgaspar dpgaspar deleted the chore/remove-deprecated-apis-3 branch June 12, 2023 13:17
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants