Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add BurdaForward to "In the Wild" and merge "News" and "Entertainment" to "Media & Entertainment" #24339

Merged
merged 3 commits into from
Jun 9, 2023
Merged

docs: Add BurdaForward to "In the Wild" and merge "News" and "Entertainment" to "Media & Entertainment" #24339

merged 3 commits into from
Jun 9, 2023

Conversation

mattitoo
Copy link
Contributor

@mattitoo mattitoo commented Jun 9, 2023

SUMMARY

Add BurdaForward to "In the Wild" and merge "News" and "Entertainment" to "Media & Entertainment"

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Check the page if link for BurdaForward works

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

villebro
villebro requested changes Jun 9, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition - one minor comment about ordering, other than that LGTM

RESOURCES/INTHEWILD.md Outdated
Comment on lines 128 to 129
- [Prensa Iberica](https://www.prensaiberica.es/) [@zamar-roura]
- [BurdaForward](https://www.burda-forward.de/en/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please place the entries in ABC order

@mattitoo mattitoo changed the title Docs: Add BurdaForward to "In the Wild" and merge "News" and "Entertainment" to "Media & Entertainment" docs: Add BurdaForward to "In the Wild" and merge "News" and "Entertainment" to "Media & Entertainment" Jun 9, 2023
@mattitoo mattitoo requested a review from villebro June 9, 2023 09:50
villebro
villebro approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 65bfe2e into apache:master Jun 9, 2023
27 of 28 checks passed
@mattitoo mattitoo deleted the docs-add_burdaforward_inthewild branch June 9, 2023 11:26
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mattitoo @villebro @mistercrunch