Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove deprecated api /superset/tables/<int:db_id>/... #24342

Merged
merged 8 commits into from
Jun 12, 2023
Merged

chore: remove deprecated api /superset/tables/<int:db_id>/... #24342

merged 8 commits into from
Jun 12, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jun 9, 2023

SUMMARY

Removes old deprecated API /superset/tables/<int:db_id>/... use /api/v1/database/<int:pk>/tables/ instead

Effort on removing deprecated APIs from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 9, 2023 •
edited
Loading

Codecov Report

Merging #24342 (b40fefc) into master (2df699c) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head b40fefc differs from pull request most recent head e04c657. Consider uploading reports for the commit e04c657 to get more accurate results

@@            Coverage Diff             @@
##           master   #24342      +/-   ##
==========================================
- Coverage   69.08%   69.06%   -0.03%     
==========================================
  Files        1903     1903              
  Lines       74590    74564      -26     
  Branches     8107     8107              
==========================================
- Hits        51534    51500      -34     
- Misses      20945    20953       +8     
  Partials     2111     2111
Flag Coverage Δ
hive 53.80% <ø> (+0.01%) ⬆️
mysql 79.35% <ø> (-0.04%) ⬇️
postgres 79.42% <ø> (-0.03%) ⬇️
presto 53.72% <ø> (+0.01%) ⬆️
python 83.34% <ø> (-0.04%) ⬇️
sqlite 77.95% <ø> (-0.04%) ⬇️
unit 54.21% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.68% <ø> (-0.36%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

michael-s-molina
michael-s-molina reviewed Jun 9, 2023
View reviewed changes
UPDATING.md Outdated
@@ -24,6 +24,7 @@ assists people when migrating to a new version.

## Next

- [-](https://github.com/apache/superset/pull/-): Removed deprecated API `/superset/tables/<int:db_id>/<schema>/...`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you move this to the breaking changes section and add the PR number?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is strange I think we used to only have Next and potential downtime, since all that lands on Next would somewhat be a minor breaking change. What's the difference between Next and Breaking changes on this context?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is that in Next we add things that are not breaking changes but might be helpful when upgrading.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think is just a form of separating things you should really be careful when upgrading from things you might find useful or interesting.

@john-bodley john-bodley mentioned this pull request Jun 11, 2023
Merged
9 tasks
villebro
villebro approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I suggest we wait for #24344 first and make sure the perf issue is fixed on both code paths before merging this.

@villebro
Copy link
Member

FYI @dpgaspar #24344 is now merged

michael-s-molina
michael-s-molina approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit e0253a4 into apache:master Jun 12, 2023
29 checks passed
@dpgaspar dpgaspar deleted the chore/remove-deprecated-apis-4 branch June 12, 2023 14:31
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

@villebro villebro villebro approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dpgaspar @villebro @john-bodley @michael-s-molina @mistercrunch