Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated apis on superset, testconn, validate_sql_json, schemas_access_for_file_upload #24354

Merged
merged 9 commits into from Jun 13, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jun 12, 2023

SUMMARY

Removes old deprecated APIs:

  • /superset/testconn
  • /superset/validate_sql_json/
  • /superset/schemas_access_for_file_upload
  • /superset/extra_table_metadata/

Effort on removing deprecated APIs from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar changed the title Chore/remove deprecated apis 6 @dpgaspar chore: remove deprecated apis on superset, testconn, validate_sql_json, schemas_access_for_file_upload Jun 12, 2023
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #24354 (500e824) into master (c04bd4c) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 500e824 differs from pull request most recent head 6f5efe3. Consider uploading reports for the commit 6f5efe3 to get more accurate results

@@            Coverage Diff             @@
##           master   #24354      +/-   ##
==========================================
- Coverage   69.05%   69.02%   -0.04%     
==========================================
  Files        1903     1903              
  Lines       74378    74275     -103     
  Branches     8110     8110              
==========================================
- Hits        51363    51268      -95     
+ Misses      20903    20895       -8     
  Partials     2112     2112              
Flag Coverage Δ
hive 53.98% <100.00%> (+0.09%) ⬆️
mysql 79.34% <100.00%> (-0.04%) ⬇️
postgres 79.41% <100.00%> (-0.04%) ⬇️
presto 53.90% <100.00%> (+0.09%) ⬆️
python 83.37% <100.00%> (-0.03%) ⬇️
sqlite 77.92% <100.00%> (-0.05%) ⬇️
unit 54.39% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.52% <100.00%> (-1.12%) ⬇️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar changed the title @dpgaspar chore: remove deprecated apis on superset, testconn, validate_sql_json, schemas_access_for_file_upload chore: remove deprecated apis on superset, testconn, validate_sql_json, schemas_access_for_file_upload Jun 12, 2023
@dpgaspar dpgaspar changed the title chore: remove deprecated apis on superset, testconn, validate_sql_json, schemas_access_for_file_upload chore: remove deprecated apis on superset, testconn, validate_sql_json, schemas_access_for_file_upload, extra_table_metadata Jun 13, 2023
@dpgaspar dpgaspar merged commit 6f145df into apache:master Jun 13, 2023
29 checks passed
@dpgaspar dpgaspar deleted the chore/remove-deprecated-apis-6 branch June 13, 2023 10:03
@dpgaspar dpgaspar changed the title chore: remove deprecated apis on superset, testconn, validate_sql_json, schemas_access_for_file_upload, extra_table_metadata chore: remove deprecated apis on superset, testconn, validate_sql_json, schemas_access_for_file_upload Jun 14, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants