Use static (uploaded) image as dashboard thumbnail #24373
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dinesh-zemoso
changed the title
dinesh-zemoso
changed the title
| @@ -436,13 +436,13 @@ class D3Format(TypedDict, total=False): | |||
| # and doesn't work with all nested types. | |||
| "PRESTO_EXPAND_DATA": False, | |||
| # Exposes API endpoint to compute thumbnails | |||
| "THUMBNAILS": False, | |||
| "THUMBNAILS": True, | |||
There was a problem hiding this comment.
@dinesh-zemoso you probably don't want to change the default configuration. You can refer to the documentation in CONTRIBUTING.md regarding how to provide local overrides.
| # ### end Alembic commands ### | ||
|
|
||
| def downgrade(): | ||
| pass |
There was a problem hiding this comment.
Please add a downgrade which restores the table to its previous state.
|
@dinesh-zemoso just checking in to see if you're able to follow through on this. Thanks in advance! |
| "CACHE_TYPE": "NullCache", | ||
| "CACHE_NO_NULL_WARNING": True, | ||
| 'CACHE_TYPE': 'redis', | ||
| 'CACHE_DEFAULT_TIMEOUT': 24*60*60*7, |
There was a problem hiding this comment.
Could you use the timedelta instead (example) to improve readability.
| @@ -645,8 +645,10 @@ class D3Format(TypedDict, total=False): | |||
| THUMBNAIL_CHART_DIGEST_FUNC: Optional[Callable[[Slice, ExecutorType, str], str]] = None | |||
|
|
|||
| THUMBNAIL_CACHE_CONFIG: CacheConfig = { | |||
| "CACHE_TYPE": "NullCache", | |||
| "CACHE_NO_NULL_WARNING": True, | |||
| 'CACHE_TYPE': 'redis', | |||
| @@ -1296,7 +1298,7 @@ def EMAIL_HEADER_MUTATOR( # pylint: disable=invalid-name,unused-argument | |||
| # chrome: | |||
| # Requires: headless chrome | |||
| # Limitations: unable to generate screenshots of elements | |||
| WEBDRIVER_TYPE = "firefox" | |||
| WEBDRIVER_TYPE = "chrome" | |||
| @@ -1317,7 +1319,7 @@ def EMAIL_HEADER_MUTATOR( # pylint: disable=invalid-name,unused-argument | |||
| WEBDRIVER_OPTION_ARGS = ["--headless"] | |||
|
|
|||
| # The base URL to query for accessing the user interface | |||
| WEBDRIVER_BASEURL = "http://0.0.0.0:8080/" | |||
| WEBDRIVER_BASEURL = "http://localhost:8088/" | |||
| @@ -160,6 +160,7 @@ class Dashboard(Model, AuditMixinNullable, ImportExportMixin): | |||
| published = Column(Boolean, default=False) | |||
| is_managed_externally = Column(Boolean, nullable=False, default=False) | |||
| external_url = Column(Text, nullable=True) | |||
| static_image = Column(Text, nullable=True) | |||
There was a problem hiding this comment.
Shouldn't this be a BLOB (or similar) if we're storing a binary object. Additionally could you talk to any performance concerns this could have, i.e., the payload for fetching a record will likely increase significantly.
I'm not sure if having a separate table to house these images makes more sense.
SUMMARY
User can choose a static image as the dashboard thumbnail
Here is the discussion link : #18872
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION