Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allows new values for single value filters #24388

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Allows new values for single value filters. This feature already exists for multiple value filters.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-06-13.at.10.56.06.mov

TESTING INSTRUCTIONS

Check that single value native filters allow free form text.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #24388 (85794e6) into master (a3aacf2) will decrease coverage by 0.09%.
The diff coverage is 89.36%.

❗ Current head 85794e6 differs from pull request most recent head 1c7b183. Consider uploading reports for the commit 1c7b183 to get more accurate results

@@            Coverage Diff             @@
##           master   #24388      +/-   ##
==========================================
- Coverage   69.05%   68.96%   -0.09%     
==========================================
  Files        1903     1904       +1     
  Lines       74530    74095     -435     
  Branches     8105     8121      +16     
==========================================
- Hits        51464    51101     -363     
+ Misses      20955    20881      -74     
- Partials     2111     2113       +2     
Flag Coverage Δ
javascript 55.65% <84.74%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...acy-preset-chart-deckgl/src/components/Tooltip.tsx 0.00% <0.00%> (ø)
...lugins/plugin-chart-table/src/utils/formatValue.ts 66.66% <0.00%> (-3.93%) ⬇️
...c/components/Chart/DrillDetail/DrillDetailPane.tsx 75.32% <ø> (ø)
...end/src/components/Datasource/DatasourceEditor.jsx 65.35% <ø> (ø)
...-frontend/src/components/TableCollection/index.tsx 100.00% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 2.04% <ø> (ø)
...end/src/dashboard/components/SliceHeader/index.tsx 90.56% <ø> (ø)
...mponents/DataTablesPane/components/SamplesPane.tsx 97.67% <ø> (ø)
...ataTablesPane/components/SingleQueryResultPane.tsx 85.71% <ø> (ø)
...erset-frontend/src/profile/components/fixtures.tsx 100.00% <ø> (ø)
... and 22 more

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit dc042c6 into apache:master Jun 15, 2023
26 checks passed
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Jun 15, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants