Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated apis /slice_json/ and /annotation_json/ #24423

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

dpgaspar
Copy link
Member

SUMMARY

Removes old deprecated APIs:

  • /superset/slice_json/...
  • /superset/annotation_json/...

Effort on removing deprecated APIs from /superset: #24332

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #24423 (10a11d6) into master (23bb1c4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 10a11d6 differs from pull request most recent head 59ca5f7. Consider uploading reports for the commit 59ca5f7 to get more accurate results

@@            Coverage Diff             @@
##           master   #24423      +/-   ##
==========================================
+ Coverage   68.91%   68.93%   +0.01%     
==========================================
  Files        1904     1904              
  Lines       73920    73879      -41     
  Branches     8119     8119              
==========================================
- Hits        50944    50929      -15     
+ Misses      20865    20839      -26     
  Partials     2111     2111              
Flag Coverage Δ
hive 53.94% <100.00%> (+0.02%) ⬆️
mysql 79.25% <100.00%> (+0.04%) ⬆️
postgres 79.34% <100.00%> (+0.04%) ⬆️
presto 53.87% <100.00%> (+0.01%) ⬆️
python 83.33% <100.00%> (+0.05%) ⬆️
sqlite 77.84% <100.00%> (+0.04%) ⬆️
unit 54.64% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/utils.py 83.13% <ø> (+2.14%) ⬆️
superset/views/core.py 70.34% <100.00%> (+1.67%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit d6a61c1 into apache:master Jun 16, 2023
29 checks passed
@dpgaspar dpgaspar deleted the chore/remove-deprecated-apis-12 branch June 16, 2023 14:14
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants