fix: Viz migration adjustments - 2

[michael-s-molina]

SUMMARY

Makes adjustments to the viz migrations to fix problems found during tests.

• Adjusts the TreeMap migration to preserve the Sort Descending checkbox value
• Adjusts the Dual Line migration to add the filters to both Query A and Query B

@jinghua-qa

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24429 (a6a471a) into master (c69634d) will increase coverage by 0.11%.
The diff coverage is 90.98%.

❗ Current head a6a471a differs from pull request most recent head 6aaa108. Consider uploading reports for the commit 6aaa108 to get more accurate results

@@            Coverage Diff             @@
##           master   #24429      +/-   ##
==========================================
+ Coverage   68.90%   69.02%   +0.11%     
==========================================
  Files        1903     1901       -2     
  Lines       74070    73974      -96     
  Branches     8110     8119       +9     
==========================================
+ Hits        51041    51058      +17     
+ Misses      20917    20805     -112     
+ Partials     2112     2111       -1     

Flag	Coverage Δ
hive	53.90% <67.62%> (+0.03%)	⬆️
mysql	79.40% <92.07%> (?)
postgres	79.49% <92.07%> (+0.16%)	⬆️
presto	53.82% <67.62%> (+0.02%)	⬆️
python	83.47% <92.73%> (+0.26%)	⬆️
sqlite	77.99% <91.40%> (?)
unit	54.60% <66.51%> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts	100.00% <ø> (ø)
...acy-preset-chart-deckgl/src/components/Tooltip.tsx	0.00% <0.00%> (ø)
...preset-chart-deckgl/src/layers/Geojson/Geojson.jsx	0.00% <0.00%> (ø)
...et-chart-deckgl/src/layers/Geojson/controlPanel.ts	50.00% <ø> (ø)
...lugins/plugin-chart-table/src/utils/formatValue.ts	66.66% <0.00%> (-3.93%)	⬇️
superset-frontend/src/SqlLab/fixtures.ts	100.00% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js	40.93% <0.00%> (-0.25%)	⬇️
...c/components/Chart/DrillDetail/DrillDetailPane.tsx	75.32% <ø> (ø)
...-frontend/src/components/TableCollection/index.tsx	100.00% <ø> (ø)
...end/src/dashboard/components/SliceHeader/index.tsx	90.56% <ø> (ø)
... and 154 more

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[sadpandajoe]

I see we have a function called _migrate_temporal_filter as we migrate more viz in the future, is a test needed to make sure we return the right data when calling this function?

[michael-s-molina]

I see we have a function called _migrate_temporal_filter as we migrate more viz in the future, is a test needed to make sure we return the right data when calling this function?

Hi @sadpandajoe. I added tests for this function at the migrations level but we can definitely move the tests to the base class in the next batch of migrations in 4.0.