fix: Revert to old endpoint temporarily to enable sharing saved queries

[jfrag1]

SUMMARY

This PR is an alternative option to #24301 for re-enabling sharing saved queries; it simply reverts the change that broke it.

The long term fix for this will depend on the outcome of a future SIP

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #24434 (d9fae3d) into master (01689b4) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d9fae3d differs from pull request most recent head d90f6f8. Consider uploading reports for the commit d90f6f8 to get more accurate results

@@            Coverage Diff             @@
##           master   #24434      +/-   ##
==========================================
- Coverage   68.93%   68.93%   -0.01%     
==========================================
  Files        1904     1904              
  Lines       73879    73879              
  Branches     8119     8119              
==========================================
- Hits        50928    50927       -1     
- Misses      20840    20841       +1     
  Partials     2111     2111              

Flag	Coverage Δ
javascript	55.65% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js	69.16% <ø> (-0.27%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[john-bodley]

@jfrag1 thanks for the change. Is there any reason you opted for this approach as opposed to keeping the new endpoint and relaxing the SavedQueryFilter filter criterion? I guess the merit with the later is it's clearer how this works as opposed to the somewhat magical (and obscure) FAB REST API endpoint.

[jfrag1]

@john-bodley The main reason I did it this way is that I'm pretty sure there are several FAB-generated endpoints under the SavedQueryRestApi that utilize the SavedQueryFilter (set as the base_filter on the class), and I didn't want to change the behavior for those. For example, the endpoint that fetches a list of a user's saved queries could start returning a list of all saved queries with that change.