fix: Native filter dynamic numeric search #24506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Jun 23, 2023
| @@ -1852,13 +1852,13 @@ def get_sqla_query( # pylint: disable=too-many-arguments,too-many-locals,too-ma | |||
| elif op == utils.FilterOperator.LESS_THAN_OR_EQUALS.value: | |||
| where_clause_and.append(sqla_col <= eq) | |||
| elif op in { | |||
| utils.FilterOperator.ILIKE, | |||
| utils.FilterOperator.LIKE, | |||
| utils.FilterOperator.ILIKE.value, | |||
There was a problem hiding this comment.
The "value" option is not required but I added this for consistency.
| }: | ||
| if target_generic_type != GenericDataType.STRING: | ||
| sqla_col = sa.cast(sqla_col, sa.String) | ||
|
|
||
| if utils.FilterOperator.LIKE.value: | ||
| if op == utils.FilterOperator.LIKE.value: |
There was a problem hiding this comment.
Oops. Previously both LIKE and ILIKE were being materialized as LIKE.
justinpark
approved these changes
Jun 23, 2023
Codecov Report
@@ Coverage Diff @@
## master #24506 +/- ##
=======================================
Coverage 69.06% 69.06%
=======================================
Files 1901 1901
Lines 74019 74019
Branches 8116 8116
=======================================
Hits 51121 51121
Misses 20787 20787
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
john-bodley
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jun 23, 2023
(cherry picked from commit b9824d6)
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Addresses an issue with #24418 with handling
LIKEvs.ILIKE.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION