Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tags): move tags from navbar to settings #24518

Merged
merged 5 commits into from
Jun 28, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jun 26, 2023

SUMMARY

With the new designs, we are going to move tags into the right menu settings under manage. Also we going to hide all entities from the nav completely. Users will be able to see all entities by going to Tags -> clicking one of the tags see all entities page

Screen Shot 2023-06-27 at 1 01 11 PM

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh
Copy link
Member Author

hughhhh commented Jun 26, 2023

/testenv up

@github-actions
Copy link
Contributor

@hughhhh Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #24518 (c6cf945) into master (036294a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head c6cf945 differs from pull request most recent head f98588d. Consider uploading reports for the commit f98588d to get more accurate results

@@            Coverage Diff             @@
##           master   #24518      +/-   ##
==========================================
- Coverage   69.07%   69.07%   -0.01%     
==========================================
  Files        1902     1902              
  Lines       74024    74010      -14     
  Branches     8117     8117              
==========================================
- Hits        51134    51121      -13     
+ Misses      20779    20778       -1     
  Partials     2111     2111              
Flag Coverage Δ
hive 53.89% <91.66%> (-0.01%) ⬇️
mysql 79.41% <100.00%> (-0.01%) ⬇️
postgres 79.49% <100.00%> (-0.01%) ⬇️
presto 53.78% <91.66%> (-0.01%) ⬇️
python 83.48% <100.00%> (-0.01%) ⬇️
sqlite 78.00% <91.66%> (-0.01%) ⬇️
unit 54.64% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...superset-ui-core/src/chart/models/ChartMetadata.ts 100.00% <ø> (ø)
...hart-echarts/src/BigNumber/BigNumberTotal/index.ts 50.00% <ø> (-16.67%) ⬇️
...arts/src/BigNumber/BigNumberWithTrendline/index.ts 50.00% <ø> (-16.67%) ⬇️
.../plugins/plugin-chart-echarts/src/BoxPlot/index.ts 50.00% <ø> (ø)
...d/plugins/plugin-chart-echarts/src/Funnel/index.ts 50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Gauge/index.ts 50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Graph/index.ts 50.00% <ø> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/index.ts 25.00% <ø> (ø)
...tend/plugins/plugin-chart-echarts/src/Pie/index.ts 50.00% <ø> (ø)
...nd/plugins/plugin-chart-echarts/src/Radar/index.ts 50.00% <ø> (ø)
... and 21 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@hughhhh hughhhh merged commit a846e8a into apache:master Jun 28, 2023
31 checks passed
@hughhhh hughhhh deleted the hxgh-tags-move branch June 28, 2023 06:53
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants