fix(sqllab): Add threshold for checking inactive queries #24536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24536 +/- ##
==========================================
- Coverage 69.06% 68.93% -0.14%
==========================================
Files 1901 1903 +2
Lines 74019 74027 +8
Branches 8116 8118 +2
==========================================
- Hits 51121 51027 -94
- Misses 20787 20889 +102
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -201,8 +201,8 @@ export function estimateQueryCost(queryEditor) { | |||
| }; | |||
| } | |||
|
|
|||
| export function clearInactiveQueries() { | |||
| return { type: CLEAR_INACTIVE_QUERIES }; | |||
| export function clearInactiveQueries(interval) { | |||
There was a problem hiding this comment.
Where is this function being called with an interval?
There was a problem hiding this comment.
Good catch. I pushed the missing part.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There's a issue that triggered preview query has gone occasionally. It is because the CLEAR_INACTIVE_QUERIES trigger in a 2s batch time but some queries can be added at the time to verify the inactive queries.
This commit adds the threshold to check the inactive queries to fix the problem.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
after--flushing-preview-queries.mov
Before:
before--flushing-preview-queries.mov
TESTING INSTRUCTIONS
Try to choose tables to make a preview query and open new tab for additional request for preview queries
ADDITIONAL INFORMATION