fix(ssh): Editting Database w/ SSH Tunneling #24552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24552 +/- ##
=======================================
Coverage 69.08% 69.08%
=======================================
Files 1906 1906
Lines 74114 74115 +1
Branches 8155 8155
=======================================
+ Hits 51200 51201 +1
Misses 20795 20795
Partials 2119 2119
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@hughhhh Can you add a description explaining the PR? |
|
🏷️ preset:2023.27 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Jul 6, 2023
(cherry picked from commit d041648)
|
@hughhhh can you add a test for this change too? |
michael-s-molina
added
the
v3.0
michael-s-molina
pushed a commit
that referenced
this pull request
Jul 26, 2023
(cherry picked from commit d041648)
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
User's aren't able to update/edit ssh tunnel setting for any DBs inside superset. This PR fixes the API to first establish the ssh tunnel before doing a test connection.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION