Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: better styling alerts/reports modal #24558

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Improve styling of the alerts/reports modal.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screenshot 2023-06-29 at 14-45-53 Superset

After:

Screenshot 2023-06-29 at 14-52-13 Superset

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested a review from a team as a code owner June 29, 2023 21:53
@betodealmeida betodealmeida changed the title Styling custom width chore: better styling alerts/reports modal Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #24558 (6e9d4ca) into master (be9eb0f) will increase coverage by 13.81%.
The diff coverage is 100.00%.

❗ Current head 6e9d4ca differs from pull request most recent head a300aaf. Consider uploading reports for the commit a300aaf to get more accurate results

@@             Coverage Diff             @@
##           master   #24558       +/-   ##
===========================================
+ Coverage   55.26%   69.08%   +13.81%     
===========================================
  Files        1906     1906               
  Lines       74157    74156        -1     
  Branches     8161     8161               
===========================================
+ Hits        40985    51232    +10247     
+ Misses      31053    20805    -10248     
  Partials     2119     2119               
Flag Coverage Δ
hive 53.94% <ø> (?)
javascript 55.79% <100.00%> (-0.01%) ⬇️
mysql 79.39% <ø> (?)
postgres 79.48% <ø> (?)
presto 53.84% <ø> (?)
python 83.48% <ø> (+28.78%) ⬆️
sqlite 78.04% <ø> (?)
unit 54.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/features/alerts/AlertReportModal.tsx 54.90% <100.00%> (-0.12%) ⬇️

... and 327 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -17,14 +17,14 @@
"""update_tag_model_w_description

Revision ID: 240d23c7f86f
Revises: 6fbe660cac39
Revises: 8e5b0fb85b9a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this fixing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We currently have 2 heads in Alembic, this chains the 2 (independent heads) so there's just one.

@betodealmeida betodealmeida merged commit aa6870b into master Jun 30, 2023
56 of 57 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the styling_custom_width branch March 26, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants