Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change naming convention for count metric on Dataset creation #24609

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 6, 2023

SUMMARY

Change the name of the default metric to COUNT(*) instead of just count

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh changed the title change naming convention for count metric bug: change naming convention for count metric on Dataset creation Jul 6, 2023
@hughhhh hughhhh changed the title bug: change naming convention for count metric on Dataset creation fix: change naming convention for count metric on Dataset creation Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #24609 (4ef77f9) into master (64d728f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 4ef77f9 differs from pull request most recent head a2a3351. Consider uploading reports for the commit a2a3351 to get more accurate results

@@           Coverage Diff           @@
##           master   #24609   +/-   ##
=======================================
  Coverage   69.09%   69.09%           
=======================================
  Files        1906     1906           
  Lines       74107    74107           
  Branches     8165     8165           
=======================================
  Hits        51207    51207           
  Misses      20777    20777           
  Partials     2123     2123           
Flag Coverage Δ
hive 54.14% <0.00%> (ø)
mysql 79.48% <100.00%> (ø)
postgres 79.56% <100.00%> (ø)
presto 54.04% <0.00%> (ø)
python 83.53% <100.00%> (ø)
sqlite 78.13% <100.00%> (ø)
unit 54.79% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/datasets/commands/create.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit c573cfc into apache:master Jul 7, 2023
33 of 36 checks passed
@hughhhh hughhhh deleted the ds-creation-metric-count branch July 7, 2023 17:08
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 7, 2023
@sadpandajoe
Copy link
Contributor

🏷️ preset:2023.27

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 10, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants