Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): missing column meta on autocomplete #24611

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

Hotfix for regression from #24371
After table extended metadata discarded from sqlLab state, columns are no longer exists within extendedTables.
This commit adds the logic to extract the columns metadata from rdk query selectors.
FYI: Since AceEditorWrapper is hard to test the autocomplete specs, I'm planning to add specs for this including other autocomplete items in the upcoming PRs that will refactor setWords by a hook

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

after--columns-meta.mov

Before:

before--columns-meta.mov

TESTING INSTRUCTIONS

Enable autocomplete
Type some column name and check the autocomplete list including column names

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@justinpark
Copy link
Member Author

cc: @sadpandajoe

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM given that tests will be added in a follow-up.

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 7, 2023
@EugeneTorap
Copy link
Contributor

Hi @rusackas @kgabryje! Can we merge it?

@michael-s-molina
Copy link
Member

Hi @rusackas @kgabryje! Can we merge it?

@EugeneTorap It's generally a good practice to let the PR author to merge their PRs if they are committers to avoid ahead of time merges. @justinpark is a committer 😉

@justinpark justinpark merged commit ca8c8d2 into apache:master Jul 11, 2023
27 checks passed
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
Co-authored-by: Justin Park <justinpark@apache.org>
(cherry picked from commit ca8c8d2)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants