Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure metrics is an array in Mixed Chart #24643

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

In a Mixed Chart metadata from examples db (Average and Sum Trends), metrics and metrics_b is a single value instead of an array. This PR fixes that + adds failsafe in Mixed Chart metrics array spreading

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Add Average and Sum Trends chart to a dashboard, make sure it loads correctly

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #24643 (b949333) into master (c53b249) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head b949333 differs from pull request most recent head f499356. Consider uploading reports for the commit f499356 to get more accurate results

@@            Coverage Diff             @@
##           master   #24643      +/-   ##
==========================================
+ Coverage   68.97%   69.06%   +0.08%     
==========================================
  Files        1907     1907              
  Lines       74153    74153              
  Branches     8182     8182              
==========================================
+ Hits        51148    51213      +65     
+ Misses      20882    20817      -65     
  Partials     2123     2123              
Flag Coverage Δ
hive 54.14% <ø> (?)
postgres 79.56% <ø> (ø)
presto 54.04% <ø> (ø)
python 83.50% <ø> (+0.18%) ⬆️
sqlite 78.12% <ø> (ø)
unit 54.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.78% <ø> (ø)
superset/examples/birth_names.py 70.00% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit fe2c14f into apache:master Jul 10, 2023
30 checks passed
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants