Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update UI dev libs and fix warnings & vulnerabilities #24648

Merged
merged 9 commits into from
Jul 11, 2023

Conversation

EugeneTorap
Copy link
Contributor

@EugeneTorap EugeneTorap commented Jul 10, 2023

SUMMARY

  • Update webpack libs
  • Update babel libs
  • Update eslint libs
  • Update @svgr/webpack lib
  • Use Optional Chaining in 15 files after updating @typescript-eslint/eslint-plugin and @typescript-eslint/parser libs

BEFORE SCREENSHOTS

173 vulnerabilities (137 moderate, 31 high, 5 critical)

image

Fix caniuse-lite is outdated WARNING

image

Fix @typescript-eslint/typescript-estree WARNING

image

AFTER SCREENSHOTS

139 vulnerabilities (106 moderate, 28 high, 5 critical)

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #24648 (6addeea) into master (c53b249) will increase coverage by 0.07%.
The diff coverage is 50.00%.

❗ Current head 6addeea differs from pull request most recent head b92108b. Consider uploading reports for the commit b92108b to get more accurate results

@@            Coverage Diff             @@
##           master   #24648      +/-   ##
==========================================
+ Coverage   68.97%   69.05%   +0.07%     
==========================================
  Files        1907     1907              
  Lines       74153    74153              
  Branches     8182     8177       -5     
==========================================
+ Hits        51148    51207      +59     
+ Misses      20882    20826      -56     
+ Partials     2123     2120       -3     
Flag Coverage Δ
javascript 55.76% <50.00%> (+<0.01%) ⬆️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.78% <ø> (ø)
superset-frontend/src/components/Icons/Icon.tsx 0.00% <ø> (ø)
...tersConfigModal/FiltersConfigForm/DefaultValue.tsx 9.09% <0.00%> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts 46.96% <0.00%> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 69.76% <0.00%> (ø)
...features/annotationLayers/AnnotationLayerModal.tsx 58.97% <ø> (ø)
...ntend/src/features/annotations/AnnotationModal.tsx 50.98% <ø> (ø)
...end/src/features/cssTemplates/CssTemplateModal.tsx 56.09% <ø> (ø)
superset/datasets/commands/create.py 100.00% <ø> (ø)
superset/examples/birth_names.py 70.00% <ø> (ø)
... and 8 more

... and 12 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@EugeneTorap
Copy link
Contributor Author

Hi @rusackas @michael-s-molina @kgabryje! Can you review the PR?

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for all the package bumps and cleaning house!

@rusackas rusackas merged commit 117435f into apache:master Jul 11, 2023
33 checks passed
@EugeneTorap EugeneTorap deleted the chore/update-ui-dev-libs branch July 11, 2023 03:58
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants