Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move deprecated default version to 4.0.0 #24689

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

dpgaspar
Copy link
Member

SUMMARY

since 3.0.0 is cut. We need to move the deprecated decorator/endpoints to 4.0.0 now

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dpgaspar dpgaspar changed the title Chore/move deprecated version chore: move deprecated version Jul 13, 2023
@dpgaspar dpgaspar changed the title chore: move deprecated version chore: move deprecated default version to 4.0.0 Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #24689 (6195b44) into master (a156816) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 6195b44 differs from pull request most recent head b045507. Consider uploading reports for the commit b045507 to get more accurate results

@@            Coverage Diff             @@
##           master   #24689      +/-   ##
==========================================
- Coverage   68.97%   68.93%   -0.04%     
==========================================
  Files        1902     1902              
  Lines       74007    74007              
  Branches     8186     8186              
==========================================
- Hits        51047    51020      -27     
- Misses      20839    20866      +27     
  Partials     2121     2121              
Flag Coverage Δ
hive 54.12% <100.00%> (ø)
mysql 79.35% <100.00%> (ø)
postgres ?
presto 54.02% <100.00%> (ø)
python 83.37% <100.00%> (-0.08%) ⬇️
sqlite 78.03% <100.00%> (ø)
unit 54.84% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/base.py 73.33% <ø> (ø)
superset/views/core.py 70.34% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 13, 2023
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit ca68250 into apache:master Jul 13, 2023
33 of 34 checks passed
@dpgaspar dpgaspar deleted the chore/move-deprecated-version branch July 13, 2023 21:22
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants