Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import database engine validation #24697

Merged
merged 5 commits into from Jul 20, 2023

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Jul 14, 2023

SUMMARY

Fixes improves URI validation when importing databases, will work for importing datasets also.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #24697 (14c36c2) into master (65fb8e1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 14c36c2 differs from pull request most recent head a11867a. Consider uploading reports for the commit a11867a to get more accurate results

@@           Coverage Diff           @@
##           master   #24697   +/-   ##
=======================================
  Coverage   68.97%   68.98%           
=======================================
  Files        1901     1901           
  Lines       74006    74014    +8     
  Branches     8182     8182           
=======================================
+ Hits        51045    51056   +11     
+ Misses      20840    20837    -3     
  Partials     2121     2121           
Flag Coverage Δ
hive 54.11% <44.44%> (-0.01%) ⬇️
mysql 79.36% <77.77%> (+<0.01%) ⬆️
postgres 79.45% <77.77%> (+<0.01%) ⬆️
presto 54.01% <44.44%> (-0.01%) ⬇️
python 83.46% <100.00%> (+0.01%) ⬆️
sqlite 78.04% <77.77%> (+<0.01%) ⬆️
unit 54.86% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/databases/commands/importers/v1/utils.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dpgaspar dpgaspar added 2.1.1 v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Jul 14, 2023
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpgaspar dpgaspar merged commit cb9b865 into apache:master Jul 20, 2023
29 checks passed
@dpgaspar dpgaspar deleted the fix/import-validation branch July 20, 2023 12:08
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Jul 21, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v2.1 v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants