Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deprecated arguments in schema #24715

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

sebastianliebscher
Copy link
Contributor

SUMMARY

Since marshmallow 3.10 passing field metadata via keyword arguments is deprecated.

To search and replace I used the following regex:

  • description=(.*)\)
  • metadata={"description": "$1"})

TESTING INSTRUCTIONS

pytest or ./scripts/tests/run.sh

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #24715 (32bc716) into master (0328dd2) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 32bc716 differs from pull request most recent head 2407895. Consider uploading reports for the commit 2407895 to get more accurate results

@@            Coverage Diff             @@
##           master   #24715      +/-   ##
==========================================
- Coverage   68.97%   68.88%   -0.09%     
==========================================
  Files        1901     1901              
  Lines       74008    74008              
  Branches     8183     8183              
==========================================
- Hits        51047    50982      -65     
- Misses      20840    20905      +65     
  Partials     2121     2121              
Flag Coverage Δ
hive ?
mysql 79.35% <100.00%> (ø)
postgres 79.44% <100.00%> (ø)
presto 54.01% <100.00%> (ø)
python 83.27% <100.00%> (-0.19%) ⬇️
sqlite 78.03% <100.00%> (ø)
unit 54.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/row_level_security/schemas.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit 11bb8c3 into apache:master Jul 18, 2023
30 checks passed
@sebastianliebscher sebastianliebscher deleted the update_schema branch July 25, 2023 19:42
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants