Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add currencies controls in control panels #24718

Merged
merged 9 commits into from
Aug 2, 2023

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Jul 17, 2023

SUMMARY

PRs #24517 and #24594 introduced support for currencies for saved metrics defined on dataset level. This PR introduces currencies controls in control panel, which applies the currency formatting for all metrics in the chart.
Additionally, it restyles the column config popover in Table chart - introduced tabs "Display" and "Formatting" to make the popover cleaner.
Also, previously World Map didn't have number format control (nor a customize section). I added a Customize section and put number formatting and currency formatting in it.
The change affects all charts that already supported currencies for saved metrics - most of Echarts (including all Timeseries), Table, Pivot Table, World Map, Heatmap.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

New popover layout in Table chart:

image image

Currency control in control panel:

image

Newly added Customize section in World Map:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kgabryje kgabryje changed the title Feat/table currency feat: Add currencies controls in control panels Jul 17, 2023
@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #24718 (62b2ca3) into master (b8a3eef) will decrease coverage by 0.01%.
The diff coverage is 50.87%.

❗ Current head 62b2ca3 differs from pull request most recent head 7d36aee. Consider uploading reports for the commit 7d36aee to get more accurate results

@@            Coverage Diff             @@
##           master   #24718      +/-   ##
==========================================
- Coverage   67.17%   67.17%   -0.01%     
==========================================
  Files        1902     1904       +2     
  Lines       73939    73965      +26     
  Branches     8176     8188      +12     
==========================================
+ Hits        49672    49684      +12     
- Misses      22154    22166      +12     
- Partials     2113     2115       +2     
Flag Coverage Δ
javascript 55.75% <50.87%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-heatmap/src/controlPanel.tsx 57.14% <ø> (ø)
.../legacy-plugin-chart-heatmap/src/transformProps.js 0.00% <ø> (ø)
.../legacy-plugin-chart-world-map/src/controlPanel.ts 25.00% <ø> (ø)
...egacy-plugin-chart-world-map/src/transformProps.js 0.00% <ø> (ø)
...harts/src/BigNumber/BigNumberTotal/controlPanel.ts 30.00% <ø> (ø)
...rts/src/BigNumber/BigNumberTotal/transformProps.ts 0.00% <ø> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 16.66% <ø> (ø)
...BigNumber/BigNumberWithTrendline/transformProps.ts 48.57% <ø> (ø)
...s/plugin-chart-echarts/src/Funnel/controlPanel.tsx 66.66% <ø> (ø)
... and 40 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley
Copy link
Member

@kgabryje would you mind adding some screenshots to the PR description?

@kgabryje
Copy link
Member Author

Thanks @john-bodley, added

@kgabryje
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@kgabryje Ephemeral environment spinning up at http://35.162.241.129:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@kgabryje kgabryje merged commit f7e76d0 into apache:master Aug 2, 2023
28 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

Ephemeral environment shutdown and build artifacts deleted.

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Sep 7, 2023
@mistercrunch mistercrunch added 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants