fix: Dashboard time grain in Table #24746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
the
v3.0
Codecov Report
@@ Coverage Diff @@
## master #24746 +/- ##
=======================================
Coverage 68.89% 68.89%
=======================================
Files 1901 1901
Lines 73927 73928 +1
Branches 8183 8184 +1
=======================================
+ Hits 50932 50935 +3
+ Misses 20874 20871 -3
- Partials 2121 2122 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
john-bodley
approved these changes
Jul 20, 2023
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Jul 21, 2023
(cherry picked from commit 317aa98)
michael-s-molina
added a commit
that referenced
this pull request
Jul 26, 2023
(cherry picked from commit 317aa98)
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes a bug in the
Tablechart when reacting to dashboard Time Grain changes.Follow-up of #24665
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: The time grain is incorrectly calculated and you can see duplicated quarters.
Screen.Recording.2023-07-19.at.09.44.16.mov
After: The time grain is applied correctly and there's no duplication anymore.
Screen.Recording.2023-07-19.at.09.49.33.mov
TESTING INSTRUCTIONS
Make sure Table charts works as expected when reacting to dashboard Time Grain changes.
ADDITIONAL INFORMATION