Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip no longer highlights hovered data series #24756

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes #24738.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-07-20 at 15 39 14 Screenshot 2023-07-20 at 15 32 45

TESTING INSTRUCTIONS

Check if hovered series are highlighted.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 20, 2023
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion doesn't belong to the major fix of this. LGTM

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #24756 (110c3a1) into master (cb9b865) will increase coverage by 10.57%.
The diff coverage is 77.55%.

❗ Current head 110c3a1 differs from pull request most recent head ab9c128. Consider uploading reports for the commit ab9c128 to get more accurate results

@@             Coverage Diff             @@
##           master   #24756       +/-   ##
===========================================
+ Coverage   58.35%   68.93%   +10.57%     
===========================================
  Files        1901     1901               
  Lines       73933    73908       -25     
  Branches     8183     8176        -7     
===========================================
+ Hits        43146    50950     +7804     
+ Misses      28666    20845     -7821     
+ Partials     2121     2113        -8     
Flag Coverage Δ
javascript 55.75% <62.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <0.00%> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.76% <0.00%> (-0.03%) ⬇️
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <ø> (ø)
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)
...set-frontend/src/components/Table/VirtualTable.tsx 75.00% <ø> (ø)
superset-frontend/src/components/Table/index.tsx 75.58% <ø> (ø)
superset-frontend/src/components/Tooltip/index.tsx 100.00% <ø> (ø)
...ilters/FiltersConfigModal/FilterTitleContainer.tsx 88.23% <ø> (+8.82%) ⬆️
superset/views/database/views.py 92.68% <ø> (+62.19%) ⬆️
...gin-chart-echarts/src/Timeseries/transformProps.ts 58.46% <40.00%> (+0.64%) ⬆️
... and 14 more

... and 291 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit ac19f58 into apache:master Jul 21, 2023
26 checks passed
michael-s-molina added a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Rich tooltip" no longer highlights hovered-over data series in stacked barchart
3 participants