Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chore): switching between languages should be without timeout 60 seconds #24798

Conversation

Always-prog
Copy link
Contributor

SUMMARY

This is a fix for the problem of switching between languages. Currently, Superset has a 60-second timeout when switching languages due to using a memoized function. I added the locale as a dependency for that memoized function.

CC @bkyryliuk (44654e5)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

2023-07-25_15-57-26.mp4

After

2023-07-25_15-55-53.mp4

TESTING INSTRUCTIONS

  1. Open Superset
  2. Try to change the language twice
  3. Notice that your second attempt doesn't changed language.

ADDITIONAL INFORMATION

  • Has associated issue: Language Selection doesn't always switch language #23456
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #24798 (b1879c7) into master (cb9b865) will increase coverage by 10.60%.
The diff coverage is 74.51%.

❗ Current head b1879c7 differs from pull request most recent head ca4132d. Consider uploading reports for the commit ca4132d to get more accurate results

@@             Coverage Diff             @@
##           master   #24798       +/-   ##
===========================================
+ Coverage   58.35%   68.95%   +10.60%     
===========================================
  Files        1901     1902        +1     
  Lines       73933    73996       +63     
  Branches     8183     8195       +12     
===========================================
+ Hits        43146    51027     +7881     
+ Misses      28666    20850     -7816     
+ Partials     2121     2119        -2     
Flag Coverage Δ
hive 54.16% <48.16%> (-0.01%) ⬇️
mysql 79.19% <64.22%> (?)
postgres 79.29% <66.51%> (?)
presto 54.06% <47.70%> (+<0.01%) ⬆️
python 83.35% <74.77%> (+22.10%) ⬆️
sqlite 77.86% <63.30%> (?)
unit 54.95% <58.25%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...src/components/ColumnTypeLabel/ColumnTypeLabel.tsx 100.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/index.ts 100.00% <ø> (ø)
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <ø> (ø)
...rset-ui-chart-controls/src/sections/chartTitle.tsx 100.00% <ø> (ø)
...legacy-plugin-chart-partition/src/controlPanel.tsx 25.00% <ø> (ø)
...gins/legacy-plugin-chart-rose/src/controlPanel.tsx 50.00% <ø> (ø)
...gins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx 100.00% <ø> (ø)
.../BigNumber/BigNumberWithTrendline/controlPanel.tsx 16.66% <ø> (ø)
...s/plugin-chart-echarts/src/Funnel/controlPanel.tsx 66.66% <ø> (ø)
...ns/plugin-chart-echarts/src/Gauge/controlPanel.tsx 66.66% <ø> (ø)
... and 130 more

... and 226 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 761fec2 into apache:master Jul 25, 2023
30 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jul 26, 2023
michael-s-molina pushed a commit that referenced this pull request Jul 26, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants