chore: remove get_columns_description duplication #24819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #24819 +/- ##
==========================================
+ Coverage 68.84% 68.96% +0.12%
==========================================
Files 1902 1903 +1
Lines 73997 73996 -1
Branches 8195 8193 -2
==========================================
+ Hits 50944 51034 +90
+ Misses 20934 20846 -88
+ Partials 2119 2116 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
betodealmeida
commented
Jul 27, 2023
Comment on lines
-130
to
-140
| try: | ||
| with dataset.database.get_raw_connection(schema=dataset.schema) as conn: | ||
| cursor = conn.cursor() | ||
| query = dataset.database.apply_limit_to_sql(statements[0], limit=1) | ||
| db_engine_spec.execute(cursor, query) | ||
| result = db_engine_spec.fetch_data(cursor, limit=1) | ||
| result_set = SupersetResultSet(result, cursor.description, db_engine_spec) | ||
| cols = result_set.columns | ||
| except Exception as ex: | ||
| raise SupersetGenericDBErrorException(message=str(ex)) from ex | ||
| return cols |
There was a problem hiding this comment.
This is almost identical to get_columns_description, the only difference is the schema passed to the connection.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Small refactoring removing duplicate logic.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION