Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Add docText for long keyword #24847

Merged

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Jul 31, 2023

SUMMARY

Since the keyword tooltip is fixed size, a longer keyword name will be collapsed. This commit add docText for long keywords to enable the tooltip for the longer item.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

after--doc-text-for-long-text.mov

Before:

Screenshot 2023-07-31 at 9 42 34 AM

TESTING INSTRUCTIONS

Go to SQL Lab and enable autocomplete
Please select a schema including a long table name

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #24847 (1bf2e26) into master (e2d5046) will increase coverage by 0.01%.
Report is 9 commits behind head on master.
The diff coverage is 96.00%.

❗ Current head 1bf2e26 differs from pull request most recent head fa79fd3. Consider uploading reports for the commit fa79fd3 to get more accurate results

@@            Coverage Diff             @@
##           master   #24847      +/-   ##
==========================================
+ Coverage   68.99%   69.00%   +0.01%     
==========================================
  Files        1903     1904       +1     
  Lines       74072    74109      +37     
  Branches     8193     8195       +2     
==========================================
+ Hits        51107    51142      +35     
- Misses      20844    20848       +4     
+ Partials     2121     2119       -2     
Flag Coverage Δ
javascript 55.84% <87.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ins/legacy-preset-chart-nvd3/src/transformProps.js 7.14% <0.00%> (-0.27%) ⬇️
...t-frontend/src/components/AsyncAceEditor/index.tsx 91.66% <ø> (ø)
superset/advanced_data_type/api.py 100.00% <ø> (ø)
superset/annotation_layers/annotations/api.py 89.23% <ø> (ø)
superset/annotation_layers/annotations/schemas.py 100.00% <ø> (ø)
superset/annotation_layers/api.py 86.20% <ø> (ø)
superset/annotation_layers/schemas.py 100.00% <ø> (ø)
superset/async_events/api.py 100.00% <ø> (ø)
superset/available_domains/api.py 100.00% <ø> (ø)
superset/cachekeys/api.py 96.15% <ø> (ø)
... and 60 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @justinpark. I left some first-pass comments.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinpark justinpark merged commit 1a9c559 into apache:master Aug 2, 2023
26 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 3, 2023
michael-s-molina pushed a commit that referenced this pull request Aug 4, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants