Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validation errors appearing after ssh tunnel switch #24849

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Jul 31, 2023

SUMMARY

fixed issues with onBlur validation callbacks when user clicks the ssh tunnel toggle. Main issue was errors were still appearing after the fact when the entire forms needs to be filled out to establish an ssh tunnel connection

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@hughhhh hughhhh requested a review from eschutho July 31, 2023 21:15
@hughhhh hughhhh force-pushed the clear-validation-on-ssh branch 2 times, most recently from fe63ee7 to 0115ef5 Compare July 31, 2023 21:22
@pull-request-size pull-request-size bot added size/S and removed size/M labels Jul 31, 2023
Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Can we add or update some tests to include this prop?

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #24849 (387c40a) into master (5f10307) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is 93.10%.

❗ Current head 387c40a differs from pull request most recent head d2d3e22. Consider uploading reports for the commit d2d3e22 to get more accurate results

@@           Coverage Diff           @@
##           master   #24849   +/-   ##
=======================================
  Coverage   68.99%   69.00%           
=======================================
  Files        1904     1904           
  Lines       74081    74108   +27     
  Branches     8193     8193           
=======================================
+ Hits        51115    51137   +22     
- Misses      20845    20850    +5     
  Partials     2121     2121           
Flag Coverage Δ
javascript 55.82% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ses/DatabaseModal/DatabaseConnectionForm/index.tsx 81.81% <ø> (ø)
superset/advanced_data_type/api.py 100.00% <ø> (ø)
superset/annotation_layers/annotations/api.py 89.23% <ø> (ø)
superset/annotation_layers/annotations/schemas.py 100.00% <ø> (ø)
superset/annotation_layers/api.py 86.20% <ø> (ø)
superset/annotation_layers/schemas.py 100.00% <ø> (ø)
superset/async_events/api.py 100.00% <ø> (ø)
superset/available_domains/api.py 100.00% <ø> (ø)
superset/cachekeys/api.py 96.15% <ø> (ø)
superset/charts/api.py 87.82% <ø> (ø)
... and 43 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hughhhh hughhhh merged commit b71541f into apache:master Aug 2, 2023
26 checks passed
@hughhhh hughhhh deleted the clear-validation-on-ssh branch August 2, 2023 21:41
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 3, 2023
michael-s-molina pushed a commit that referenced this pull request Aug 4, 2023
eschutho pushed a commit that referenced this pull request Oct 20, 2023
eschutho pushed a commit that referenced this pull request Oct 20, 2023
eschutho pushed a commit that referenced this pull request Oct 20, 2023
@mistercrunch mistercrunch added 🍒 2.1.2 🍒 2.1.3 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.1.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v2.1 v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 2.1.2 🍒 2.1.3 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants