Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Added Central Asia countries to countries map #24870

Merged
merged 1 commit into from
Aug 3, 2023
Merged

feat(chart): Added Central Asia countries to countries map #24870

merged 1 commit into from
Aug 3, 2023

Conversation

Zoynels
Copy link
Contributor

@Zoynels Zoynels commented Aug 2, 2023

SUMMARY

Added Central Asia countries to countries map:

  • Kazakhstan
  • Kyrgyzstan
  • Tajikistan
  • Turkmenistan
  • Uzbekistan

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

kaz
kg
taj
tur
uz

TESTING INSTRUCTIONS

(https://superset.apache.org/docs/miscellaneous/country-map-tools/)

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #24870 (3870793) into master (1a9c559) will increase coverage by 0.00%.
Report is 2 commits behind head on master.
The diff coverage is n/a.

❗ Current head 3870793 differs from pull request most recent head 68182ac. Consider uploading reports for the commit 68182ac to get more accurate results

@@           Coverage Diff           @@
##           master   #24870   +/-   ##
=======================================
  Coverage   69.00%   69.00%           
=======================================
  Files        1904     1904           
  Lines       74107    74109    +2     
  Branches     8194     8195    +1     
=======================================
+ Hits        51140    51142    +2     
  Misses      20848    20848           
  Partials     2119     2119           
Flag Coverage Δ
javascript 55.84% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zoynels for adding these.

@john-bodley john-bodley merged commit 031e660 into apache:master Aug 3, 2023
27 checks passed
@Zoynels Zoynels deleted the central-asia-countries-to-country-map branch August 4, 2023 01:28
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants