-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: command to test DB engine specs #24918
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24918 +/- ##
==========================================
+ Coverage 67.22% 68.77% +1.54%
==========================================
Files 1906 1908 +2
Lines 74134 74390 +256
Branches 8208 8208
==========================================
+ Hits 49840 51165 +1325
+ Misses 22171 21102 -1069
Partials 2123 2123
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 99 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
430b144
to
6ff44ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, this will be a big help for people developing new specs! Just a few minor comments, LGTM
SUMMARY
This PR adds a README for DB engine specs, describing all their features and functionality. It also adds a new command to test DB engine specs, SQLAlchemy dialects, and database connections:
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION