Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused file #24946

Merged
merged 1 commit into from
Aug 10, 2023
Merged

fix: remove unused file #24946

merged 1 commit into from
Aug 10, 2023

Conversation

mdeshmu
Copy link
Contributor

@mdeshmu mdeshmu commented Aug 10, 2023 •
edited
Loading

SUMMARY

Remove unused file added by #24806 (review)

cc: @john-bodley

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backward-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing features or API

@mdeshmu mdeshmu changed the title remove unused file fix: remove unused file Aug 10, 2023
john-bodley
john-bodley approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup. I did a git rm but I may have forgotten to re-push.

@john-bodley john-bodley merged commit bcd2493 into apache:master Aug 10, 2023
29 of 31 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 10, 2023
michael-s-molina pushed a commit that referenced this pull request Aug 10, 2023
@mdeshmu @michael-s-molina
fix: remove unused file (#24946)
7a7fa74 
(cherry picked from commit bcd2493)
@mdeshmu mdeshmu deleted the cleanup-unused-file branch August 12, 2023 01:31
hughhhh pushed a commit to preset-io/superset that referenced this pull request Aug 24, 2023
@mdeshmu @hughhhh
fix: remove unused file (apache#24946)
910656a
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdeshmu @john-bodley @mistercrunch @michael-s-molina