Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): scroll position after run current sql #24965

Conversation

justinpark
Copy link
Member

SUMMARY

The scroll position after run current sql(ctrl + shift + enter) moved to bottom when hit within the first paragraph.
This commit fixes this bug by storing the current scroll after running the query.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

after--scroll-after-current-sql.mov

Before:

before--scroll-after-current-sql.mov

TESTING INSTRUCTIONS

  • type multiple sqls in the editor that makes scrollbars
  • hit running current query in the first sql paragraph
  • check the current position of the scrollbar after that

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://35.86.122.33:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@michael-s-molina
Copy link
Member

Query is failing when running without selecting the whole query.

Screen.Recording.2023-08-14.at.10.00.52.mov

@justinpark
Copy link
Member Author

Query is failing when running without selecting the whole query.

This is not a bug. you missed the semicolon in the first sql block

select *
from 'fcc survey"
where is_software_dev = 1 <-------

@justinpark
Copy link
Member Author

justinpark commented Aug 14, 2023

Query is failing when running without selecting the whole query.

@michael-s-molina This is not a bug. you missed the semicolon in the first sql block

select *
from 'fcc survey"
where is_software_dev = 1 <-------

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 15, 2023
@justinpark justinpark merged commit 155cf54 into apache:master Aug 15, 2023
27 checks passed
@justinpark justinpark deleted the fix--scroll-position-after-run-current-sql branch August 15, 2023 17:52
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

michael-s-molina pushed a commit that referenced this pull request Aug 16, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants