feat(sqllab): Add /sqllab endpoint to the v1 api #24983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Can you try to fix the tests? |
justinpark
requested review from
betodealmeida,
john-bodley,
eschutho and
michael-s-molina
| {"SQLLAB_BACKEND_PERSISTENCE": False}, | ||
| clear=True, | ||
| ) | ||
| def test_get_from_bootstrap_data(self): |
There was a problem hiding this comment.
Is this trying to test a scenario where there's no data available? If so, could you improve the test name to something like test_empty_bootstrap_data?
| {"SQLLAB_BACKEND_PERSISTENCE": True}, | ||
| clear=True, | ||
| ) | ||
| def test_get_from_backend_persistence_payload(self): |
There was a problem hiding this comment.
Maybe rename to test_bootstrap_data_queries?
| @@ -37,11 +37,76 @@ | |||
| from superset.models.sql_lab import Query | |||
|
|
|||
| from tests.integration_tests.base_tests import SupersetTestCase | |||
| from tests.integration_tests.fixtures.users import create_gamma_sqllab_no_data | |||
|
|
|||
| QUERIES_FIXTURE_COUNT = 10 | |||
|
|
|||
|
|
|||
| class TestSqlLabApi(SupersetTestCase): | |||
There was a problem hiding this comment.
Could you add a test for forbidden access?
superset/sqllab/api.py
Outdated
| {"result": result}, | ||
| default=utils.json_iso_dttm_ser, | ||
| ignore_nan=True, | ||
| encoding=None, |
There was a problem hiding this comment.
Suggested change
| encoding=None, |
superset/sqllab/api.py
Outdated
| get: | ||
| summary: Get the bootstrap data for SqlLab page | ||
| description: >- | ||
| Assembles SQLLab bootstrap data(active_tab, databases, queries, tab_state_ids |
There was a problem hiding this comment.
Suggested change
| Assembles SQLLab bootstrap data(active_tab, databases, queries, tab_state_ids | |
| Assembles SQLLab bootstrap data (active_tab, databases, queries, tab_state_ids |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Part 1-b of SQLLab SPA migration: detail link
This commit introduces new api endpoint (
/api/v1/sqllab/) and re-use the sqllab_bootstrap_data util to share the bootstrap data with the legacy landing page.We will migrate the legacy bootstrap util by a command class after the SPA initiative is completed.
TESTING INSTRUCTIONS
1 - Execute the API tests
2 - All tests should pass
ADDITIONAL INFORMATION