chore: rename get_iterable

[betodealmeida]

SUMMARY

get_iterable has a confusing name, I changed it to something more clear.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[michael-s-molina]

Maybe just as_list?

[john-bodley]

I think either as_iterable or as_list is likely best.

[betodealmeida]

@john-bodley as_iterable is super confusing, because there are many things that are already iterable but will still be modified by this function, eg:

>>> from typing import Any
>>> def is_iterable(foo: Any) -> bool:
...     try:
...         iter(foo)
...     except Exception:
...         return False
...     return True
...
>>>
>>> a = (1,2,3)
>>> is_iterable(a)
True
>>> as_iterable(a)
[(1, 2, 3)]

[betodealmeida]

And to be clear, I think this function could be called as_iterable, but then it should be improved to not check if the passed object is a list, but instead use an improved version of the is_iterable function above, something like this:

def is_iterable(foo: Any) -> bool:
    if isinstance(foo, str):
        return False
    try:
        iter(foo)
    except Exception:
        return False
    return True

But that might introduce bugs. In this PR I just want to fix the erroneous name.

[john-bodley]

Nice!