fix(embedded sdk): Remove trailing slash from passed superset domain if there is one #25020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eschutho
reviewed
Aug 24, 2023
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@superset-ui/embedded-sdk", | |||
| "version": "0.1.0-alpha.9", | |||
| "version": "0.1.0-alpha.10", | |||
There was a problem hiding this comment.
side note, when do you think we should we consider this not an alpha feature and bump the sdk to a stable version?
There was a problem hiding this comment.
I don't really have a strong opinion on this, but maybe it makes sense to do soon simply due to it being released for over a year now with no major issues? cc @lilykuang who may have more context
eschutho
approved these changes
Aug 24, 2023
eschutho
deleted the
jack/remove-trailing-slash-from-passed-superset-domain
branch
michael-s-molina
added
the
v3.0
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Without this change, passing a domain name with a trailing slash would result in the dashboard not loading with no error.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION