Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix line break in Apache Druid page #25034

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

giuliotal
Copy link
Contributor

SUMMARY

Added line breaks and highlighted using code formatting each keyword of the connection string

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

ADDITIONAL INFORMATION

Fixes #25033

@mdeshmu
Copy link
Contributor

mdeshmu commented Aug 21, 2023

@giuliotal druid.mdx is failing the linter because of spaces at the ends of lines. If you can clean that up by hand or by running pre-commit run --all-files this should pass CI and be mergeable :)

ping @sfirke !

@sfirke
Copy link
Member

sfirke commented Aug 21, 2023

Agreed with @mdeshmu. While you are at it, could you also add "the" so it reads "in favor of the" in that first sentence?

@giuliotal
Copy link
Contributor Author

@mdeshmu replaced line breaks (which required trailing white spaces) with a bullet list

image

The alternative is to use raw HTML, preferred a bullet list for clarity

Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfirke sfirke merged commit 5e56871 into apache:master Aug 21, 2023
28 checks passed
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Fix line break formatting in Apache Druid page
5 participants