Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Error when using the legacy dataset editor #25057

Merged
merged 3 commits into from
Aug 23, 2023
Merged

fix: Error when using the legacy dataset editor #25057

merged 3 commits into from
Aug 23, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes an error that was happening when using the legacy dataset editor:

File "python3.9/site-packages/flask_appbuilder/fields.py", line 128, in <genexpr>
    self._object_list = list((str(self.get_pk_func(obj)), obj) for obj in objs)

Using git bisect, I was able to pinpoint #23680 as the root cause for the error.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: An error was thrown when accessing the legacy editor

Screenshot 2023-08-22 at 17 02 06

After: The editor rendered correctly

Screenshot 2023-08-22 at 17 01 35

TESTING INSTRUCTIONS

1 - Set DISABLE_LEGACY_DATASOURCE_EDITOR to False
2 - Edit a dataset using the legacy dataset editor
3 - It should render the legacy dataset editor

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

michael-s-molina and others added 2 commits August 22, 2023 17:47
@michael-s-molina
fix: Error when using the legacy dataset editor
2b375e0
@michael-s-molina @john-bodley
Renames variable
3b414e2 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
@michael-s-molina michael-s-molina force-pushed the fix-legacy-datasource-editor branch 2 times, most recently from 6ece1b8 to 3b414e2 Compare August 22, 2023 21:47
@michael-s-molina michael-s-molina merged commit c92a975 into apache:master Aug 23, 2023
29 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 23, 2023
michael-s-molina added a commit that referenced this pull request Aug 23, 2023
@michael-s-molina
fix: Error when using the legacy dataset editor (#25057)
b5f7f54 
Co-authored-by: John Bodley <4567245+john-bodley@users.noreply.github.com>
(cherry picked from commit c92a975)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

@john-bodley john-bodley john-bodley approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michael-s-molina @dpgaspar @john-bodley @mistercrunch