Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): rendering performance regression by resultset #25091

Conversation

justinpark
Copy link
Member

@justinpark justinpark commented Aug 25, 2023

SUMMARY

When ResultSet renders a large size of column record (i.e. preview of FCC 2018 Survey), rendering cost of VirtualizedTable is heavy. To avoid the lag of the typing editor, we should avoid the ResultSet rendering while typing.
This commit fixes the inefficient userSelector in ResultSet which triggers the re-rendering of FilterableTable anytime redux action triggered.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After (no lag while typing):

after--rendering-regression-resultset.mov

Before (lagging after render the table resultset):

before--rendering-regression-resultset.mov

TESTING INSTRUCTIONS

Load example db
Go to SQL Lab and select the 'FCC 20218 Survey' in the table schema
After the preview result loaded, type the sql in the editor to check the lagging

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the PR @justinpark!

@justinpark justinpark merged commit 72150eb into apache:master Aug 28, 2023
26 checks passed
@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch and removed v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Aug 29, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants