Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removing renderCard from Tags/index.tsc to remove cardview from Tags ListView #25105

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

fisjac
Copy link
Contributor

@fisjac fisjac commented Aug 28, 2023

SUMMARY

Tags were being displayed with an option to view as cards. This was not part of the design of the tags feature.
To remove the cards from the ListView component, I removed the renderCard prop from from the TagList component to prevent card option settings from rendering in the ListView component.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image
After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@john-bodley john-bodley changed the title feat: removing renderCard from Tags/index.tsc to remove cardview from Tags feat: removing renderCard from Tags/index.tsc to remove cardview from Tags ListView Aug 29, 2023
@john-bodley
Copy link
Member

@fisjac thanks for the change. Would you mind adding a more descriptive PR description as well as a before and after screenshot? This would significantly help the review process.

@jinghua-qa
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@jinghua-qa Ephemeral environment spinning up at http://35.93.7.79:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@hughhhh hughhhh merged commit 66e2807 into apache:master Aug 30, 2023
36 checks passed
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

darwinsubramaniam pushed a commit to darwinsubramaniam/superset that referenced this pull request Sep 7, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants