Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DB Connection): Update placeholder values for Snowflake connection #25119

Merged
merged 2 commits into from
Aug 30, 2023
Merged

fix(DB Connection): Update placeholder values for Snowflake connection #25119

merged 2 commits into from
Aug 30, 2023

Conversation

Vitor-Avila
Copy link
Contributor

SUMMARY

The placeholder values for the Account and Database fields on the Snowflake dynamic form were swapped. This PR fixes this issue.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Snowflake_dynamic_form_before

Snowflake_dynamic_form_after

TESTING INSTRUCTIONS

Only changes static text. Spin up Superset and validate the changes in the dynamic form.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

kgabryje
kgabryje approved these changes Aug 30, 2023
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit 46a0a6e into apache:master Aug 30, 2023
27 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 31, 2023
michael-s-molina pushed a commit that referenced this pull request Aug 31, 2023
@Vitor-Avila @michael-s-molina
fix(DB Connection): Update placeholder values for Snowflake connection (
e2f89d7 
#25119)

(cherry picked from commit 46a0a6e)
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Sep 1, 2023
@Vitor-Avila @sadpandajoe
fix(DB Connection): Update placeholder values for Snowflake connection (
24908e5 
apache#25119)

(cherry picked from commit 46a0a6e)
@sadpandajoe
Copy link
Contributor

🏷️ preset:2023.35

darwinsubramaniam pushed a commit to darwinsubramaniam/superset that referenced this pull request Sep 7, 2023
@Vitor-Avila @darwinsubramaniam
fix(DB Connection): Update placeholder values for Snowflake connection (
906db33 
apache#25119)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@Vitor-Avila
fix(DB Connection): Update placeholder values for Snowflake connection (
732ba17 
apache#25119)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Vitor-Avila @sadpandajoe @kgabryje @mistercrunch @michael-s-molina